Hi rjsaulakh,

A lot of suggestions for you:

• Use strict and warnings to make your life easier.
• Indent your code to better show the control flow
• Use the 3-argument form of open, and always check for success or failure.
• Always close files as soon as you're done reading from them.
• Use chomp (or chop) to remove the trailing newline, especially if the line represents a filename.
• Use foreach to easily iterate through lists

Putting them all together, you get the simplified:

#!/usr/bin/perl

# Always use these
use strict;
use warnings;

# Edit contains the complete path of the files to be edited
my $path = "/home/rjs/heena/edit" ;

# Getting a file handler (and test for success/failure!)
open(FL, "<", $path) or die "unable to open data file '$path' ($!)\n";

# Getting all the file names in the @array so that i can process the
# file one by one
chomp(my @array = <FL>);

# Close the data file
close(FL);

# Process each file
foreach my $file (@array) {
    next if ($file =~ /^\s*$/);   # Skip blank lines from datafile
    open(FILE, "<", $file) or die "unable to open file '$file' ($!)\n"
+;
    while(<FILE>) {
        s/CONFIDENTIAL(.*?)own\s+risk/ /sm;
        print;
    }
    close(FILE);
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.