That won't work when one of the elements is 0, "", "0", undef, etc. Check the size of @one, not whether $entry is true or false. 

while (@one) {
   push(@two, pop(@one));
}

[download]

Of course, using reverse would be even better.

.oO( Why doesn't pop return an empty list for an empty array, allowing while (my ($item) = pop(@array))? )

Update: For fun, a few ways to reverse a list: 

my @b = reverse(@a);

my @b = sub { my @rv; push(@rv, pop()) while @_; return @rv }->(@a);

my @b = sub { my @rv; unshift(@rv, shift()) while @_; return @rv }->(@
+a);

my @b = map { $a[-$_] } reverse 0..$#a;

my @b = map { $a[-$_] } -$#a..0;

my @b = map { $a[$_] } sort { $b <=> @a } 0..$#a;

my @b = map { $a[$_] } sub { my @rv; push(@rv, pop()) while @_; return
+ @rv }->(0..$#a);

my @b = map { $a[$_] } sub { my @rv; unshift(@rv, shift()) while @_; r
+eturn @rv }->(0..$#a);

my @b = @a[ reverse 0..$#a ];

my @b = @a[ map { -$_ } -$#a..0 ];

my @b = @a[ sort { $b <=> @a } 0..$#a ];

my @b = @a[ sub { my @rv; push(@rv, pop()) while @_; return @rv }->(0.
+.$#a) ];

my @b = @a[ sub { my @rv; unshift(@rv, shift()) while @_; return @rv }
+->(0..$#a) ];

[download]

I keep thinking of more, such as a counting loop...

In reply to Re: Reversing an array. Subroutine. by ikegami
in thread Reversing an array. Subroutine. by Pearte

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.