My, oh my! You have far too many my's in your code/

Each my for the same variable will mask the previous contents of that variable so it is effectively lost to your script. So only use my once for each variable.

As for opening and reading your text files, I don't know how large they are, but if they have quite a size, the web-server will take a big hit if for every access to your script it has to read a huge file just to get a few random lines. In such case it is much better to put all your lines in database and get the content from the database.

Finally, where did you get the random_line subroutine? I see it nowhere defined in your script, so I would be surprised if it works.

PS: I wouldn't bother with finding the second to last letter of the input and using that as a randomizing device. Just do a straight random pick out of all of your lines of spam-quotes. It will work as good and none will be the wiser.

CountZero

"If you have four groups working on a compiler, you'll get a 4-pass compiler." - Conway's Law

In reply to Re: will this random-text script work? how do i integrate a template? by CountZero
in thread will this random-text script work? how do i integrate a template? by hawthorne

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.