Without running the snippet what does this print:

sub foo { return 'hello' unless $_[0]; } print "First: " . foo(1) . "\n"; print "Second: " . foo(0) . "\n";

I have to admit I did not expect this, I expected to get nothing in the first case, not the value of the condition.

This comes from a test script for XML::Rules in which, in a filter, I had the following code:

my $parser_remove = XML::Rules->new( rules => [ _default => 'raw', line => sub { my ($tag, $attrs, $context, $parents) = @_; if ($attrs->{_content} =~ /\s+NOT\s+/) { $parents->[-2]{_remove} = 1; # skip the <lines> and se +t the attribute directly in <address> } return [$tag => $attrs]; }, address => sub { return $_[0] => $_[1] unless ($_[1]->{_remove}); } ], style => 'filter', );
It should remove all <address> tags that contain a <line> that contains \s+NOT\s+. Instead of just removing the said tags the code replaces them by "1", that is the value of the $_[1]->{_remove}. It did not take long to find the problem in this case, but still I think it's worth noting, in case someone makes the same mistake in a more complex code.


In reply to Value of a statement with modifier by Jenda

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.