Am I close?
So close, yet so far away.
- I notice a lot of undeclared variables. Adding use strict; will show these errors. Adding use warnings; will also help you find errors.
- How do you plan on executing the expression? While it's possible, your approach is fundamentally flawed.
- %scores flattens to a key-value-key-value-... list. You probably want keys(%scores).
- The keys of a hash are returned in an unpredictable order, yet you assume they are returned in the order in which they were added to the hash.
- $grade contains an undesireable trailing newline.
- != is used for numerical comparisons. "43>=50" is not a number.
- $grade is used for two different purposes.
- You variable names are wonky. $grade contains a score and %scores is used to lookup grades.
- You table is wonky. "D" the same as "B". What if the score is 92? What if the score is 46?
Update: I had kept my solution hidden since it sounded like a homework question. Since others have posted theirs, I'll reveal mine:
use strict;
use warnings;
my %grade_lookup = (
90 => "A",
80 => "B",
70 => "C",
60 => "D",
);
my $score = <STDIN>;
chomp($score);
my $grade = "F";
foreach my $gate_score (sort { $a <=> $b } keys %grade_lookup) {
if ( $score >= $gate_score ) {
$grade = $grade_lookup{$gate_score};
}
}
print("$score is $grade\n");
But since we want an ordered lookup table, why not use an array?
use strict;
use warnings;
my @grade_lookup = reverse(
[ 90 => "A" ],
[ 80 => "B" ],
[ 70 => "C" ],
[ 60 => "D" ],
);
my $score = <STDIN>;
chomp($score);
my $grade = "F";
foreach (@grade_lookup) {
if ( $score >= $_->[0] ) {
$grade = $_->[1];
}
}
print("$score is $grade\n");
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.