The one that gets me presently is "return" statement with explicit "undef" at line 942, column 5. See page 199 of PBP. I'd like to know when being explicit has ever been a problem. I'm almost tempted to buy that book just to see what the argument is on page 199. Almost.

Update: Ahh, I see... I hadn't thought about list context since the function only ever returns scalars and the results are all checked with if defined $scalar_name. I'm going to go ahead and stick with return undef if $something for functions that only return scalars and consider the advice given by Perl::Critic to be educated guesses or tips.

-Paul

In reply to Re: Module Announcement: Perl-Critic-1.01 by jettero
in thread Module Announcement: Perl-Critic-1.01 by jthalhammer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.