first, some code:
for my $artistkey (0..$#is_guest) { # Don't do anything if the artist is not a guest next if ($is_guest[$artistkey] == 0); # IF the artist exists, we need only to update some information my $sth = $dbh->prepare("SELECT FROM artists (alias) WHERE alias = +?"); $sth->execute($artist_alias[$artistkey]); # The Part In Question: if ($sth->rows >= 1) { my $sth = $dbh->prepare("UPDATE artists SET email=? WHERE alias= +?"); $sth->execute($email[$artistkey], $artist_alias[$artistkey]); } # Now for Redundancy next if ($sth->rows >= 1); my $sth = $dbh->prepare("INSERT INTO artists (alias, email, is_gues +t) VALUES (?, ?, ?)"); $sth->execute($artist_alias[$artistkey], $email[$artistkey], $is_gu +est[$artistkey]); }

I'd like to avoid that little bit about redundancy. If at all possible, i'd like to consolidate the 'if' statement and the 'next if' into one, while still doing what's in the brackets. In an effort to reduce redundancy, I made the following changes. The following change gave me problems at compile time:

next if ($sth->rows >= 1) { my $sth = $dbh->prepare("UPDATE artists SET email=? WHERE alias= +?"); $sth->execute($email[$artistkey], $artist_alias[$artistkey]); }

Any ideas?

--Coplan


In reply to Test break, but still doing by Coplan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.