- appearing to be contrary to the first line of the code, the node-named directories are one level higher than where the ordinary files for the node are located.

- as a good habit, follow glob with an expression that includes the '*' in single quotes -- "*" is prone to be dereferenced by Perl before the glob() gets called.

- grep and glob could be combined more succinctly and therefore readably - sometimes opendir etc fits better than glob in the code - in this case both seem to have their place.

- where a path is used more than once in the code, put it in a variable early on to avoid data duplication (maintainability). Consider also putting paths, regexps and filenames in configuration files to avoid hardcoding completely.

For example ... 

my $tree = "/appl/perform/workspace/htdocs/node_reports";
opendir my $dh, $tree or die $!;
for my $node ( grep !( /^\./ || /^lost\+found$/), readdir $dh ) {
    print "$_\n" for grep !/^business_use\.$node$/, glob join( '/', $t
+ree, $node, '*' );
}
closedir $dh;

[download]

-M

Free your mind

In reply to Re: Regex Basics by Moron
in thread Regex Basics by mbeason

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.