i have one problem the sshd_config sometime looks like this 
#Port 22
Port 4444

[download]
After we modify the file with above code it becomes like this 
Port 4444
Port 4444

[download]

Right, that's what your code in the OP does, and that's what I mentioned in my third "bullet" paragraph as probably being a bug.

Now, you seem to be saying that you simply want to delete all commented lines (the ones beginning with "#"), which is easy enough to do: 

while (<SSHD_CONFIG>) {
    next if ( /^#/ );
    s/^port.+/Port $sshport/i;
    print SSHD_CONFIG_NEW;
}

[download]
But some people prefer to leave the comment lines in, because sometimes these lines hold important information that might be useful someday (e.g. documentation, or details about a prior or alternative configuration that might be needed when conditions change).

That's why the version in my first reply used the parens and the "$1" in the s/// statement, to preserve the "#" character while changing the port number. Actually, I think it may be best to retain the comment lines unchanged, and only edit the "uncommented" line -- this also turns out to be the simplest method: 

while (<SSHD_CONFIG>) {
    s/^port.+/Port $sshport/i;
    print SSHD_CONFIG_NEW;
}

[download]

In reply to Re^3: Defactor this code by graff
in thread Defactor this code by xerophyte

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.