You should push the grepped list onto @matched, not assign. The way it is written you only match the last date. Besides, the grep is messed up.

You should also use strict and warnings; Data::Dumper is not used in your script, so nothing will be printed (and you don't get a warning).

The corrected script:

#!/usr/bin/perl use warnings; use strict; use Data::Dumper; my $driver = "<dirlist.csv"; open DRV , $driver or die "Cannot open $driver: $!"; while( <DRV> ){ chomp; my ($dirname) = shift; checkExistingDates($dirname); } close DRV; sub checkExistingDates{ my $dirname = shift; my @datelist = ("20030901", "20061017", "20050406", "20070101", "2 +0080202"); my @fileslist = ("DIR22.20060816", "DIR22.20050919", "DIR22.200610 +17", "DIR22.20060516", "DIR22.20050406"); my @matched = (); foreach my $date (@datelist) { push (@matched, grep {/$date/} @fileslist); } print Dumper @matched; }

But the hash solution mentioned above is much better.

Upd: btw, $dirname is read from the command line, not from the file. I suppose you meant something along the lines of my $dirname = $_ or my $dirname = (split /,/)[0].


In reply to Re: Grepping arrays, any better way to do this? by akho
in thread Grepping arrays, any better way to do this? by chanakya

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.