Hi djbryson,

Other people have already pointed out the issue around the arguments to push - I thought it might be worth adding that:

What you're doing will put each column from the database into your array, one after another, and squdge them all together. E.g. if one set of results looked like this: (1, 2, 3) then after three fetches your array of results would look like this: (1, 2, 3, 1, 2, 3, 1, 2, 3)

You might be better either
a) putting a reference to @result onto @dept, like this: push @dept, \@result (or you could use fetchrow_arrayref), or
b) using fetchall_arrayref

Either way, instead of a data structure that looks like this: (1, 2, 3, 1, 2, 3, 1, 2, 3) I'd suggest using a data structure like this:

( [1, 2, 3], [1, 2, 3], [1, 2, 3] )
as you'll find it easier to work with when you come to do whatever you're going to do with it. You can find more info about this kind of thing in perlref.

HTH! a.

update: of course, if you're only fetching one column at a time then the way you have it is already perfectly sensible, and not worth changing...


In reply to Re: push result into array by andye
in thread push result into array by djbryson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.