Read the new lines into a new list then push the new lines onto the end of the master list:

use strict; use warnings; my @list; foreach my $DIR qw(TEST_DIR WINS_DIR) { if (defined($ENV{"$DIR"})) { my $filename = $ENV{"$DIR"} . "/common/wins.ini"; if (-s $filename) { open (IN,$filename); my @newList = <IN>; close (IN); chomp @newList; push @list, @newList; } } }

Note too the use of strictures: use strict; use warnings;. All your code should use strictures!

Update: You may find that using next cleans up the code by reducing nesting thus making it easier to see the important program flow:

use strict; use warnings; my @list; foreach my $DIR qw(TEST_DIR WINS_DIR) { next unless defined($ENV{"$DIR"}); my $filename = $ENV{"$DIR"} . "/common/wins.ini"; next unless -s $filename; open (IN,$filename); my @newList = <IN>; close (IN); chomp @newList; push @list, @newList; }

Oh, and you should use the three parameter open too. ;)

open IN, '<', $filename;

DWIM is Perl's answer to Gödel

In reply to Re: Adding to array by GrandFather
in thread Adding to array by pglenski

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.