Hi beckheng. Here are some suggestions for you:

You aren't really using Exporter here. I think you should. Put in a line like this in PBB::Packages::MyConfigTest: 

our @EXPORT_OK = qw(%stash);

[download]
And then call it from PBB::ControllerTest like this: 
use PBB::Packages::MyConfigTest qw(%stash);

[download]
Then you can get rid of the line with the *stash typeglob and the use vars qw(%stash) line. I suggest you put your use strict in PBB::ControllerTest right after the package declaration and add a use warnings.

Don't make $q and $t global variables. You're only using them in your handler() sub, so just declar them there as lexical (my) variables.

In general, you should be using our instead of use vars these days.

When I talked to you on use.perl.org, it sounded like you didn't want those file names added to the end of your array ref. What you're showing here though looks like you're trying to append two entries to the end of this array reference, which is best done with a push, like you had before.

In reply to Re: Please share your advice about my mod_perl program by perrin
in thread Please share your advice about my mod_perl program by beckheng

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.