You shouldn't ever directly include data that is provided by a user in your SQL. It should always be bound, or quoted where binding isn't available.
# Interpolated ... bad
my $sql = "insert into hits (browser) values ('$ENV{HTTP_USER_AGENT}')
+"
$dbh->do($sql);
# Bound ... best
my $sql = "insert into hits (browser) values (?)";
$dbh->do($sql, {}, $ENV{HTTP_USER_AGENT});
# Quoted ... tolerable
my $sql = sprintf "insert into hits (browser) values (%s)", $dbh->quot
+e($ENV{HTTP_USER_AGENT});
$dbh->do($sql);
It is trivial for users to modify their user agent string, never trust users.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.