I'm getting an error I've been unable to shake for the past couple of hours. It reads:

The count of critical failures is 0.
Count of critical failures: 0
Use of uninitialized value in numeric eq (==) at lib/Test/MonitorSites
+.pm line 183.

[download]
And the code that generates it reads:

  my $critical_failures = $self->_analyze_test_logs();
  print STDERR "Count of critical failures: $critical_failures->{'coun
+t'}\n";
  if($critical_failures->{'count'} != '0'){ # line 183
    $self->sms($critical_failures);
  } elsif ($self->{'config'}->param('global.report_success') == 1) {
    $self->sms($critical_failures);
  } else {
    $self->{'error'} .= "We won't send an sms, there were no critical_
+failures and global.report_success is not set true.\n";
  }

   .   .   .

sub _analyze_test_logs {
  my $self = shift;
  my $critical_failures = 0;
  my %critical_failures;
  $critical_failures{'count'} = 0;

    .   .   .   

  $critical_failures{'count'} = $critical_failures;
  if($critical_failures{'count'} == 0){
    print STDERR "The count of critical failures is 0.\n";
  }

  return \%critical_failures;
}

[download]
I've quoted and unquoted the zero on line 183, without effect. I've tried, actually started, using the '>' operator instead of '!='. But I'm stumped here. Any ideas why zero would not be equal to zero, or why a variable defined on one line would be reported as uninitialized on the very next line?

UPDATE

Ikegami: you're good. I had in fact emitted an elsif clause in my efforts to simplify the situation. I have now restored that clause to the code above with this update. Now I'll go add some debugging statements to try to track down what I now suspect may be a missing configuration paramater. I'll report back on what I learn in a few minutes.

UPDATE #2

Ikegami: That was it. I just added a patch to my constructor which defines the $self->{'config'}->param('global.report_success') value if its missing. Thanks again! I think that just might make this ready the release of a new version.

-- Hugh

if( $lal && $lol ) { $life++; }

In reply to Defined values errors out as unitialized by hesco

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.