Hi everyone. Is there anyway I can really improve the following small piece of code for a little program that deals with CGI for the internet, where you have a web page that has say 3 links on it leading to other relative pages on the site. When you click on a link you want it to take you to another page and stuff, and it uses the GET command and stuff from the cool CGI.pm parser. In short, I was just wondering how I could improve this code to make it as efficient as I can. It's a really simple little CGI program in Perl, but it's just for a future project of mine, and I would like to know if it needs to be changed around a bit or a lot.


#!/usr/bin/perl -wT
use strict;
use CGI ':all';
use CGI::Carp qw(fatalsToBrowser);

if (param('page') eq "") {
    &index;
}

elsif (param('page') eq "page2") {
    &page2;
}

elsif (param('page') eq "page3") {
    &page3;
}

sub index {
    print header(),
        start_html('INDEX'),    
        '<p>This is the index page!<br><br>',
        '<a href=index.pl?page=>index</a><br>',
        '<a href=index.pl?page=page2>page2</a><br>',
        '<a href=index.pl?page=page3>page3</a><br>',
        end_html();
}

sub page2 {
    print header(),
        start_html('PAGE_2'),    
        '<p>This is page2!<br><br>',
        '<a href=index.pl?page=>index</a><br>',
        '<a href=index.pl?page=page2>page2</a><br>',
        '<a href=index.pl?page=page3>page3</a><br>',
        end_html();
}

sub page3 {
    print header(),
        start_html('PAGE_3'),    
        '<p>This is page3!<br><br>',
        '<a href=index.pl?page=>index</a><br>',
        '<a href=index.pl?page=page2>page2</a><br>',
        '<a href=index.pl?page=page3>page3</a><br>',
        end_html();
}

[download]



Thanks for any help in advance! Bye now.

bladx ~ a seeker of many perl questions

Edit: 2001-03-03 by neshura

In reply to Improving the efficiency of this piece of code by bladx

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.