a whole heap of key=value pairs, easy enough. but I want to see if I can optimise what I already have done

I guess that depends on how you define "optimise". That could mean reusing existing code (thereby optimizing development time) unless there is a reason not to (such as computational speed, which is another thing that can be optimized).

Since your input is a bunch of "key=value" pairs, you could use one of the many config modules that parse ini-like files.

use warnings; use strict; use Config::General; my $string = 'to=<adam.clark@ngv.vic.gov.au>, relay=monet1.ngv.vic.gov +.au[10.10.10.20]:25, delay=0.54, delays=0.06/0.02/0/0.46, dsn=2.0.0, +status=sent '; $string =~ s/, /\n/g; my $conf = Config::General->new( -String => $string ); my %hash = $conf->getall(); while( my ( $k, $v ) = each %hash ) { print "$k => $v\n"; }
Prints:
to => <adam.clark@ngv.vic.gov.au> relay => monet1.ngv.vic.gov.au[10.10.10.20]:25 dsn => 2.0.0 status => sent delay => 0.54 delays => 0.06/0.02/0/0.46


In reply to Re: Adapting parenthesis in regexps by bobf
in thread Adapting parenthesis in regexps by cyzza

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.