Why not use a perl style foreach loop: 
foreach my $host_num ( 0..num_hosts()-1 ) {
    print "[$host_num] ", hostname_by_num($host_num), "\n" ;
}

[download]

Better yet why not change the lookup function to index from 1 and prevent accidentally mucking about with HOSTS. 

use Scalar::Util qw(looks_like_number);

sub hostname_by_num { 
    my $num = shift;

    # validate our argument
    defined $num
       or return undef;
    $num >= 1
       or return undef;
    looks_like_number( $num )
       or return undef;

    $num--;  # convert into array index.

    return exists $HOSTS[$num] ? $HOSTS[$num] : undef;
}

[download]

Now you can simplify choose_host. 

sub choose_host {
    my $chosen_host;
    while ( !defined $chosen_host ) {
        printchoices();
        $chosen_host = hostname_by_num( getchoice() );
    }

    return $chosen_host;
}

# for loop can now be:
sub printchoices {
    print join "\n",
        "\n",
        "ssh hosts",
        "-"x8;

    foreach my $host_num ( 1..num_hosts() ) {
        print "[$host_num] ", hostname_by_num($host_num), "\n" ;
    }
}

[download]

The concatenation in ssh_string is hard to read, try join with a null string for assembling the return value: 

sub ssh_string {
    my $host = shift;
  
    return join '',
        username(),
        '@', 
        $host,
        domain();
}

[download]

Also, ditch the unneeded & sigil from your subroutine calls. It can have unexpected consequences. See perlsub.

Update: The relevent bits from perlsub, with emphasis added:

...If a subroutine is called using the & form, the argument list is optional, and if omitted, no @_ array is set up for the subroutine: the @_ array at the time of the call is visible to subroutine instead. This is an efficiency mechanism that new users may wish to avoid.
...
Not only does the & form make the argument list optional, it also disables any prototype checking on arguments you do provide. This is partly for historical reasons, and partly for having a convenient way to cheat if you know what you're doing. See Prototypes below.


TGI says moo

In reply to Re^2: improov mein k0den by TGI
in thread improov mein k0den by metaperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.