If I'm validating input, as in the example, I'm inclined to leave off the else. That's normally at the top of a sub, and I don't want to have the whole sub another level deep because it's all in else.

If it's more like a real branch, I might include the else. If the behavior changes so that the one branch does not exit, I want to be able to do that easily (i.e., without having to add the else).

I avoid using ternary operators for branching like this. I think of it as something that returns a value, so I don't like having it in a void context. If it's that important to save vertical space, I'd rather crowd my curlies than use a ternary.

if ( ! $sanity ) { print "Mandatory happiness violated.\n"; exit } else { print "You are happy.\n" }

...but even that I don't like much.

I'm generally of the opinion that code grows. Today's exit may be tomorrow's warn. The one line will be three. You should write it now to accommodate its growth later.


In reply to Re: Coding styles using if/else by kyle
in thread Coding styles using if/else by sulfericacid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.