I need to find a GOOD regex to pull back links from a given $url. I know, I know, don't reinvent the wheel and HTML regexes aren't practical.. and I know some will suggest some modules that'll help, too. I'd prefer a fairly decent regex if anyone has one.

Anyway, I found this code from someone else's snippet but oddly enough, when I run it I don't get back any links. Did I forget to copy a line of code or something? 

#!/usr/bin/perl

use warnings;
use strict;
use CGI qw/:standard/;
use CGI::Carp qw(fatalsToBrowser);

use LWP::UserAgent;
use LWP::Simple qw(!head);
use HTML::LinkExtor;
use URI::URL;

my $url = "http://www.test.com";

  my $url = shift;
  my @links;  
  my $ua = LWP::UserAgent->new;
  my $p = HTML::LinkExtor->new(\&callback);

  # Request document and parse it as it arrives
  my $res = $ua->request(HTTP::Request->new(GET => $url),
                      sub {$p->parse($_[0])});

for ($p->links) {
   if (defined $_->[2]) {
   push(@links, $_->[2]);
   }
}

foreach my $link (@links)
{
   print "$link<br>";
}

[download]

In reply to Can't get back links from page by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.