Definitely always use placeholders; even more, as the OP mentions an ORA error - sign that Oracle is the underlying DB - I'd go with something like the following: 

my ($db_ssn, $db_lastname, $db_birth_year, $db_store);

  my $sql = <<'END_SQL';
SELECT ssn, RTRIM(last_name,''),TO_CHAR(birth_date,'YYYY'),store
  FROM pyhadmin.py_emp_shadow
 WHERE TO_CHAR(birth_date,'YYYY') LIKE :birth_year
   AND ssn LIKE :ssn
   AND RTRIM(last_name,'  ') LIKE UPPER(:last_name)
   AND rownum <= 1
END_SQL

eval {
  my $sth = $dbh->prepare($sql);

     $sth->bind_param( ':birth_year', $year,      ORA_NUMBER );
     $sth->bind_param( ':ssn',        $ssn,       ORA_NUMBER );
     $sth->bind_param( ':last_name',  $last_name, ORA_VARCHAR2);

     $sth->execute();

  ($db_ssn, $db_lastname, $db_birth_year, $db_store)
     = $sth->fetchrow_array;

     $sth->finish();
};
if ($@) {
   # there was an fatal error; die() if you want, 
   # but maybe you can do something to recover and go on ,
   # log something, etc.
}

[download]
Have a look on DBD::Oracle for this special form of placeholders.

These aren't portable, so avoid them if your code is going to run on other DBs, but as long as you're on Oracle, the code is much easier to read/maintain like this. Also, it is a lot harder to make (typical, sometimes hard to debug) errors like swapping values for the placeholders - think about more complex queries, where you would need to (re)use the same value in more then one place.

In reply to Re^2: Quick 'Quote' DBI Question by Krambambuli
in thread Quick 'Quote' DBI Question by Trihedralguy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.