I'd strongly recommend that you use strictures (use strict; use warnings;) and declare variables so their scope is obvious. Global variables are generally frowned on as it can be pretty hard to figure out the relationship between setting and using them.

The three parameter form of open is much preferred to improve security and make io direction more explicit.

Code of the form:

for (...) {
    if (...) {
        ...
    }
}

[download]

can be rewritten:

for (...) {
    next unless ...;
    ...
}

[download]

to save a level of indentation and make the flow clearer. This becomes especially important where loops are nested.

... if ...;

[download]

is generally more Perlish than

if (...) {...;}

[download]

Perl allows labelled loops so rather than using a $break variable you can:

SCANNING: while (...) {
    ...
    for (...) {
        ...
        next SCANNING if ...;
    }

    ...
}

[download]
DWIM is Perl's answer to Gödel

In reply to Re: the axml parser v3.4 by GrandFather
in thread the axml parser v3.4 by simonodell1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.