GrandFather makes some very good points. I'll add a few:

First of all, your file writes are going to collide if two instances of your program run at the same time and try to write the same file. You need some kind of race-free file locking mechanism to prevent that. See perlopentut for a good starting point.

Your code is susceptible to the poison null byte in the request parser. Ouch! Google for that. And while you're at it, use CGI::Simple or CGI to get away from the many potential failures that exist in your request parsing code.

If you take GrandFather's very fine advice and use the strict pragma, your code will throw an ugly Error 500 if a file open fails. You should check that the opens succeed before trying to read or write a filehandle, and fail or recover gracefully if the open fails.

There are three things, I'll leave some for the other fine monks to pick on.

And again, don't be afraid of CPAN. Wouldja rather learn to work with CPAN, or release code that makes you look like a dork?

In reply to Re: the axml parser v3.4 by gloryhack
in thread the axml parser v3.4 by simonodell1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.