Hi neversaint,

First of all, you can take the duplicated foreach my $elA (@arA) { ... } loops and combine them into one:

foreach my $elA (@arA) {
    foreach my $elB (@arB) {
        if ($elA eq $elB) {
            push @{$all{$elA}}, $elB." - from Array B";
        }
    }
    foreach my $elC (@arC) {
        if ($elA eq $elC) {
            push @{$all{$elA}}, $elC ." - from Array C";
        }
    }
}
[download]

Then, simplifying each inner loop would give you:

foreach my $elA (@arA) {
    map { ($elA eq $_) and push @{$all{$elA}}, "$_ - from Array B" } @
+arB;
    map { ($elA eq $_) and push @{$all{$elA}}, "$_ - from Array C" } @
+arC;
}
[download]

And finally, if you want to get really fancy, you could abstract even further (and anticipate adding other arrays into the mix):

#!/usr/bin/perl -w

use strict;
use warnings;
use Data::Dumper;

my @arA = qw( lion tiger dog cat snake );
my @arB = qw( tiger dragon lion );
my @arC = qw( dog phoenix );

my %all;

# This is the list of arrays we want to compare against "arA",
# where the key is the label, and the value is the corresponding
# array reference.
my $p = {
    'from Array B' => \@arB,
    'from Array C' => \@arC,
};

foreach my $elA (@arA) {
    foreach my $lbl (keys %$p) {
        map { ($elA eq $_) and push @{$all{$elA}}, "$_ - $lbl" } @{$p-
+>{$lbl}};
    }
}

print Dumper %all;
# Then do some other things with %all...
[download]

I think that's about as concise as you'll get it.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.