You are iterating over the same list two four times. Why? You could write this using "foreach" and simply use conditionals to test each regex (with a push for valid values). In fact, your second "grep" only gives you a subset of your first "grep", so make sure to pay attention for things like that as you recode. You can probably also skip some regexes by using "next" within the "for" loop, if there are mutually exlusive matches.

Update: Oops. Dyslexia. Looping twice for each structure. Still once too often. (Note, I would also make those list names a little less like each other. {grin} )

In reply to (ichimunki) re: Grep Effeciency by ichimunki
in thread Grep Effeciency by ImpalaSS

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.