A couple of things in addition to the advice shmem has already given. Firstly you are not checking if the number the user has guessed is the secret number, just that it is a lower number, and you never tell the user that they have guessed correctly. Try the code below:
use strict; use warnings; my $secret=42; my $guess; while(1) { print "please enter a guess from 1 to 100: "; chomp($guess = <STDIN>); if ($guess =~ /quit|exit|^s*$/i){ print " sorry you gave up.the number was $secret.\n"; last; } if ($guess != $secret) { print "Wrong! Guess again.\n"; }else{ print "Correct!\n"; last; } }
In your example if the secret number was 42 and the user enters 43 they are not told that they have failed to guess correctly.
Please read the PerlMonks FAQ and How do I post a question effectively? if you have not alreay done so.

Hope this helps

Martin

In reply to Re: how to enable, disable strict by marto
in thread how to enable, disable strict by elsiddik

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.