Apart from the comments made above, I would suggest two things:

1) In your last while loop, you attempt to open and close a filehandle each time you come upon a match. This is highly inefficient. Open $OFILE before the loop, and close it after.

2) It would no doubt be better (or at least more elegant) to turn your @id_hits into a single regex, rather than looping through the array inside another loop. One simple way of doing this would be to add a line:

my $id_regex = join '|', @id_hits;

after the first while loop, but you could most likely create a more efficient regex if you used Regexp::Assemble

Putting that all together would give something like:

use strict;
use warnings;

use Regexp::Assemble;
my $id_regex = Regexp::Assemble->new;

my $IDFILE  = ...; # Your filenames here

open my $ifh, '<', $IDFILE or die "Could not open $IDFILE: $!";

while ( my $line = <$ifh> ) {
  $id_regex->add( substr $line, 0, 6 );
}

close $ifh;

open my $afh, '<', $AMPFILE or die "Could not open $AMPFILE: $!";
open my $ofh, '>', $OUTFILE or die "Could not open $OUTFILE: $!";

while ( my $line = <$afh> ) {
  chomp $line;
  if ( $line =~ $id_regex ) {
    my $next = <$afh>;
    print $ofh $line, "\t", $next if $next =~ /^Amp-commit/;
  }
}

close $ofh;
close $afh;

[download]

Untested, unfortunately, as I don't have access to your data files...

Belated update (sorry!): changed

    my $next = <DATA>;

to

    my $next = <$afh>;

In reply to Re: Search a file with ids from another file by Not_a_Number
in thread Search a file with ids from another file by sigzero

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.