Since there's always more than one way to do it, you could consider operating on each part of the name befor doing the join:
sub fullname { my (@parts) = @_; for my $p (@parts) { $p = length($p) > 1 ? $p : # not a single - don't change $p =~ /[a-z]/i ? $p . '.' : # single letter - add a dot $p; # not a letter - don't change } my $name = join(" ", @parts); return $name; }
Breaking it up like this might be preferable if the problem were more complex, because really long regex's can be difficult to maintain. For example, if you decided to add a dollar sign in front of single digits, you could just add this line (after the add a dot line):
$p =~ /\d/ ? '$' . $p : # single digit - add a $

This seems easier (to me) than rewriting the regex, and less likely to introduce subtle bugs due to differences in regex behavior.

Unless you're a regex master, I think it's best to keep them as simple as possible. And if you ARE a regex master, but have to work on a team where other people are NOT - then it's STILL best to keep them simple as possible!


In reply to Re: simpler regex by scorpio17
in thread simpler regex by rsiedl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.