After you do a 'prepare', you need to do an 'execute'. See the DBI documentation.

...

I don't know what type of values your data might have, but a single quote within any item will break your process. This is one of the cases where placeholders are your friend. (and if you pass 'undef' to them, then you don't have to worry about the logic for handling NULL)

my $sql = 'UPDATE table SET '
    . join (',', map {"$_=?"} @ffs)
    . 'WHERE tbl.field=?';
# check the string '$sql' -- you used 'table' in the FROM, but 'tbl' i
+n the WHERE
my $sth = $db->prepare( $sql );
$sth->execute( @cols{@ffs}, $lname );

[download]

update: fixed a couple of typos.

update 2: if the empty string is being used to signify null (and not just a bad test for undef (undef eq ''), then change the execute line to:

$sth->execute( (map { $_ eq '' ? undef : $_ } @cols{@ffs} ), $lname );

In reply to Re: Looping an array and placing into SQL by jhourcle
in thread Looping an array and placing into SQL by Quicksilver

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.