Thanks for all the feedback folks.

Zaxo addressed the issue concisely - thanks.

For the other posts that ranted about the logic, I am a bit surprised - first, because it's a bit odd to change the logic of some code to fix a warning, and second, it ignores TMTOWTDI (although the trend in paper tomes on Perl seem to be straying from that mantra).

Anyways, here's the actual code snippet (parsing S-Expr subset):

my $text;
if (($text) = $line =~ m!^\s*\((.*)\)[\r\n]+$!) {
      # keyed value
      my ($key, $val) = split( /\s+/, $text, 2 );
      $val =~ s!(^[\'\"]|[\'\"]$)!!g;
      $info->{$key} = $val;
}
elsif (($text) = $line =~ m!^\s*\'(.*)\'[\r\n]+$!) {
      # quoted value
      $text =~ s!(^[\'\"]|[\'\"]$)!!g;
      return $text;
}
elsif (my ($key) = $line =~ m!^\s*\((\S+)[\r\n]+$!) {
      # sub-level
      push @{$info->{$key} ||= []}, $self->_parse_vm_info( $lines );
}

[download]

And a solution to the warning was never very interesting to me - I had solved it by polluting the enclosing block (as above) and while I liked the single initial def by Zaxo, I chose not to use that because future edits could make the def inadvertently disappear for the 2nd block (a minor annoyance).

Onward, McPerl

In reply to Re: strange scope by anagramster
in thread strange scope by anagramster

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.