Whether you think it's good design or not, importing functions from some other .pm file and using them as methods is a common practice.

Agreed. I would say that by using a module from a plugin, you're joining what "should" be two black boxes, and those black boxes should interact via their API, and if you ignore encapsulation, then here be dragons.

What happens if the internals of the plugin change, or the internals of the module? This would be the same issue regardless of the object model.

That said, I'm sure that there are many modules that do exactly this, the authors probably wanting to save the expense of a method call, but I think it is Alter that is in the right here, and the plugin in the wrong.

clint

In reply to Re^12: Beyond Inside-Out by clinton
in thread Beyond Inside-Out by Anno

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.