I'd refactor the loop to eliminate the goto, the label, most of the nesting, and to make the intent a little clearer:

foreach my $i (0..$maxclients-1) {
    $selected[$i] = $weighteddiv[int rand @weighteddiv];
    next if $i == 0;

    # Check for duplicates
    redo if grep {$selected[$i] == $selected[$_]} 0 .. $i-1;
}

[download]

Update: s/next if/last if/ - bug pointed out by TimToady

Update: removed while loop - issue pointed out by TimToady
fixed bug due to next in foreach modified statement
fixed domain for rand - issue pointed out by TimToady

DWIM is Perl's answer to Gödel

In reply to Re: removing the goto by GrandFather
in thread removing the goto by scoobyrico

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.