You really need to use strict. If you had strict on, you'd see that $A_list was not declared anywhere. By default, a foreach loop puts each element into $_ unless you give it another variable to use. You should also check the return status of your open call to make sure there are no errors.

It also doesn't make much sense to put use LWP::Simple; and use HTML::Strip in the middle of your loop -- use statements are executed at compile time and modules are (usually) only loaded once.

With that in mind, this should get you started.

#!/usr/bin/perl use strict; use warnings; use LWP::Simple; #open text file and fill array open(MYINPUTFILE, "<A-list") or die "Can't open A-list: $!"; my(@A_in) = <MYINPUTFILE>; # read file into list #remove whitespace my @A_list = map { s/^\s+//; s/\s+$//; $_ } @A_in; close(MYINPUTFILE); #fetch each webpage foreach my $num(@A_list) { chomp $num; my $url = "http://www.hkjc.com/english/racing/horse.asp?HorseNo=$num"; my $content = get $url; die "Couldn't get $url" unless defined $content; print $content; }

In reply to Re: Grabbing many webpages with foreach by friedo
in thread Grabbing many webpages with foreach by monkeybus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.