Had a bit of a disagreement with a colleague about how much "stuff" on a single line of code is appropriate.

    my $country = $card->country;
    $country = $country eq 'gbr' ? '' : uc "[$country]" if $country;
[download]

Note that the second line has both a ternary operator and a statement modifier. One of us argued that this made the code more difficult to read and the other argued that it best reflects the business logic. I won't tell you which of us argued which in order to avoid possibly prejudicing you :)

How do you feel about that code snippet? (Even a comment about the hard-coded 'gbr' would be fine). Is it too much for one line or is it fine? If it's too much, how would you rewrite that to keep the behavior but make it easier to read?

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.