The issue is the other conditional.

If the dog is barking let him in otherwise give him a bone, but only if it is raining.

This sentence reads nicer if we place the "if it is raining" earlier in the sentence. I however, would force the truth of $country

my $country = $card->country || 'gbr';
$country = $country eq 'gbr' ? '' : uc "[$country]";

[download]

Unfortunately, this breaks when we need to check definedness (until we have a reliable // operator). In that case (assume "0" is a valid country) I would probably go with something like:

my $country = $card->country;
$country = (!defined($country) or $country eq 'gbr') ? '' : uc "[$coun
+try]";

[download]

Which is just as complex as the original, but the full conditional is easier to find.

Good Day,
    Dean

In reply to Re^3: How Much Is Too Much (on one line of code)? by duelafn
in thread How Much Is Too Much (on one line of code)? by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.