Way too much. It would almost be tolerable if it were:
  my $country = $card->country;
  $country = $country eq 'gbr' ? '' : uc "[$country]"
    if $country;

[download]
but maybe that's just me. I always put postfix modifiers on their own line, indented, unless they are for control constructs. I find them much more digestible.

<tongue where='in-cheek'>
The proper way to do this would of course be something like: 

my $country;
eval {
  my $countryId = Country::Identifier->new(id => $card->country);
  $country = Country::Factory->new(id => $countryId);
  my $cntry_formatter =
    Formatter::Factory->new(action => sub { "[" . shift() . "]" });
  $country->apply(Iterator->new(type => "closure",
                                args => [ $cntry_formatter ]));
}

[download]
but I don't have quite enough room left in the margin of this post for the error handling.
</tongue>

In reply to Re: How Much Is Too Much (on one line of code)? by sfink
in thread How Much Is Too Much (on one line of code)? by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.