A few points spring to mind. Firstly, it is strongly recommended that you put
use strict; and
use warnings; at the top of your scripts. This will force you to declare your variables, which helps avoid typos, and gives sanity warnings regarding dubious code.
When slurping files it is worth localising the change to $/ within a small scope to avoid unwanted side effects elsewhere in the script
my $header = <INFO>;
my $sequence;
{
local $/;
$sequence = <INFO>;
}
Once out of the code block, the previous value of $/ will be restored.
I don't think the code as you have posted it will even compile as it looks as if you have mismatched braces now that the foreach is commented out.
This line
$commentout = $commentout .= $position;
looks a bit wonky. Do either
$commentout = $commentout . $position;
or
$commentout .= $position;
Better still, just use one line
my $commentout = '$' . $position;
Double quotes interpolate variables, single quotes don't.
As GrandFather points out, including samples of the input files and the expected output will help us to help you.
Cheers,
JohnGG
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.