Well, the $ctr = 0 doesn't do anything useful, and the $ctr += 1 could be merged into the if conditional. 

my @converted_list = map { sprintf('0x%04x', $_) } unpack('v*', $line)
+;
    
my $ctr;
foreach (@converted_list) {
   print OUTFILE "$_, ";
   print OUTFILE "\n" unless ++$ctr % 8;
}

[download]

You could merge of all that together if you so desired, but that's probably a bit odd. 

my $ctr;
print map { ++$ctr % 8 ? "$_, " : "$_\n" }
      map { sprintf('0x%04x', $_) }
      unpack('v*', $line);

[download]

The simplest solution is probably to omit the counter altogether by only reading in 16 bytes at a time. As a bonus, it doesn't leave trailing comma when the file isn't an exact multiple of 16 bytes long. 

# Each line has 8 16-bit words, so 16 bytes.
local $/ = \16;

while (<INFILE>) {
   print join ', ',
         map { sprintf('0x%04x', $_) }
         unpack('v*', $_);
   print("\n");
}

[download]

In reply to Re^3: Convert binary file to ascii by ikegami
in thread Convert binary file to ascii by richz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.