Hi, jagh, I am not sure I understand what I would expect from this module judging from the the contained POD. I mean you don't provide enough information on the overall description. Oh, you even missed the DESCRIPTION section. This is the place you're supposed to put the idea, motivation, and the purpose of the module. It's not clear what the check_package and file_contains functions do, or whether it returns something.

You say, "espcially if you use cfengine", yet the NAME heading says "System configuration related unit tests". So, I read that as this module is usable without that cfengine thing, but I still don't know how to use it. And it's good to also briefly mention about what cfengine is, what it does, and how it relates to your module. Is your module a Perl implementation of cfengine? Or instead, does it provides interfaces to cfengine?

I would say, go ahead and expand the module, but please allow the future users to understand what the module does. Briefly explain the idea, motivation, and purpose of the module. About the name, I suggest you're looking at the Sys:: namespace to put it under. I'm sure your module will fill some gap there :)

Oh one more thing, I didn't proceed to try your module because,

Test-Sysconfig-0.01$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_h
+arness(0, 'blib/lib', 'blib/arch')" t/*.tt/00-load.........# Testing 
+Test::Sysconfig 0.01, Perl 5.008008, /usr/bin/perl
t/00-load.........ok
t/01-sysconfig....ok 1/4
#   Failed test 'perl installed'
#   in t/01-sysconfig.t at line 11.
t/01-sysconfig....NOK 2/4# Looks like you failed 1 test of 4.
t/01-sysconfig....dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 2
        Failed 1/4 tests, 75.00% okay
t/pod-coverage....ok
t/pod.............ok
Failed Test      Stat Wstat Total Fail  List of Failed
----------------------------------------------------------------------
+---------
t/01-sysconfig.t    1   256     4    1  2
Failed 1/4 test scripts. 1/7 subtests failed.
Files=4, Tests=7,  1 wallclock secs ( 0.63 cusr +  0.16 csys =  0.79 C
+PU)
Failed 1/4 test programs. 1/7 subtests failed.
make: *** [test_dynamic] Error 255

Test-Sysconfig-0.01$ perl -V
Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
  Platform:
    osname=linux, osvers=2.6.9-22.18.bz155725.elsmp, archname=i386-lin
+ux-thread-multi
    uname='linux hs20-bc1-6.build.redhat.com 2.6.9-22.18.bz155725.elsm
+p #1 smp thu nov 17 15:34:08 est 2005 i686 i686 i386 gnulinux '
[download]

Update: I didn't see any reply yet, even hours after I front-paged it in hoping to get more attention. So I just gave it a shot, eventhough I wasn't sure I understood about the module.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.