I see some improvements on the docs, and I now I understand what your module is trying to do. I just don't have yet a chance to find out if similiar solutions exist on
CPAN. Some notes:
- You may want to reconsider the check_package implementation because it's too centric on one favor of distro. I'm afraid that it's not that simple to verify that a package really exists, or even "usable" on the current system being tested.
- I see that file_contains is some kind of another grep implementation. You just can't take arbitrary string and treat is a regex. It could blow your module and something happens you don't expect.
- It's good to put a "SEE ALSO" section at the bottom of the POD and put Test::Builder::Module there, so users know where to find more information you don't need to provide
Overall, I strongly recommend you to dig more on
CPAN to find out 1) the more flexible and generic way to check package availability 2) the safer way to check file content with regex (think
eval), there is a number of
File:: modules you may find useful (althought you don't have to
use them); also you may want to improve it so your module can check more than one pattern in the target file.
Out of all, I'd still say, go ahead. Please be explicit that it's currently implemented for specific distro of specific operating system. If you find it useful for you, others may find it useful for them as well. And if they use different distro/OS, hopefully they implement that part for you. Good luck, jagh!
Open source softwares? Share and enjoy. Make profit from them if you can. Yet, share and enjoy!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.