Your regex m/<a href="\s*(.+)\s*"/g is too greedy - the .* gobbles up as much of the string as possible, so for the line

<a href="link1">link 1</a>Some text<a href="link2">link 2</a>

[download]

$1 will be

link1">link 1</a>Some text<a href="link2"

[download]

instead of what you expected:

link1

[download]

What you want to do in the first step is to make the match non-greedy, or make it stop at the first double-quote it encounters:

m/<a href="\s*(.+?)\s*"/g # non-greedy due to .*?
m/<a href="\s*([^"]+)\s*"/g # stops at first "

[download]

Neither of these solutions will work with arbitrary HTML, so if you want to rewrite HTML pages from more than one source, you will likely be better off with a HTML parser like HTML::TokeParser::Simple.

The question of how to stuff the changes back into the string is best answered by printing out the tokens you get from HTML::TokeParser::Simple, but if you first want to stick with your regular expression approach, the s/// operator will do a search-and-replace operation:

    $html =~ s!(<a href="\s*)([^"]+)(\s*")!${1}foo$2$3!g;

[download]

In reply to Re: regex question by Corion
in thread regex question by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.