afresh1 .. You probably meant that to be 
       map { $self->{$_} = $initdata{$_} } keys %initdata;

[download]
since there is no indication of the existance of a %self hash, or the relevance of such a hash to the object.
Also, there is not need for the "if" since empty "keys" will effectively convert the map to a no-op.
So your code is equivalent to the hash slice jdporter wrote.

My preference would be to simplify it to : 

  %$self =  (%$self, %initdata);

[download]
which, although representing infinitasmally more overhead, has an elegant simplicity to it.

If you really wanted to be non-destructive of $self or $_[0], you could: 

   $self->{$_}=$initdata{$_} for keys %initdata;

[download]
which, to me, is slightly more readable/DWIM, compared to a "map" whose result is thrown away.

     "An undefined problem has an infinite number of solutions." - Robert A. Humphrey         "If you're not part of the solution, you're part of the precipitate." - Henry J. Tillman

In reply to Re^2: Make sense? by NetWallah
in thread Make sense? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.