I'm gradually taking over responsibility of a codebase that uses nested evals quite a bit. Sort of like this:

eval
{
    callMethod();
};
if ($@)
{
    confess "CallMethod failed: $@";
}

[download]

with callMethod() having another one embedded, eg

sub callMethod
{
    # blah blah
    eval {
        someMoreCode();
    };
    if ($@)
    {
        confess "someMoreCode failed: $@";
    }
}

[download]

The impression I get is that some error checking is missing and this is a rough and ready way of dealing with fatal errors. It works, but for some reason, it makes me feel uncomfortable.

My instinct is telling me to get rid of these evals (while fixing exception handling), but am I just making work for myself? Or should I be embracing this exception handling technique as a tool for faster development?

edit - added bold ;-)

edit 2 - yes, the confesses were originally dies (so that explains quite a bit right there :)

In reply to Nested evals - are they evil? by cLive ;-)

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.