I have this foreach loop that I am trying to optimize for a large flat file database.
The database is a table with rows stored in the @project_module_list array and columns separated by commas.
When running on a small 50 row database, it spits the html out pretty fast. However, when running on an 800 row database, it takes an average of 9 seconds to finish running.
Can someone help me optimize this loop?

P.S. Each column has its data separated by a colon. Column element 0 is the column data, element 1 is the user who last edited it, and element 2 is the time stamp of the last edit.
Maybe there is just too much data to process it faster?

Here is the loop code:

foreach $project_module_list (@project_module_list) {
    if($moduleCount != 0) {
        @moduleData = split /,/, $project_module_list;
        print "<tr><td align=center><div class=table_data>$moduleCount
+</div></td>";
        $dataCount = 0;
        foreach $moduleData (@moduleData) {
            @moduleField = split /:/, $moduleData;
            $recentChange = "";
            $_ = $headers[$dataCount];
            $localtime = FormatTime($moduleField[2]) if $moduleField[2
+];
            $localtime = "n/a" unless $moduleField[2];
            if( /approv/i ) {
                $status = "N/A";
                if($moduleField[0]) {
                    $default = "checked";
                    $status = "$moduleField[1]";
                    $color = " bgcolor=\"#CCFF99\"";
                }
                else {
                    $default = "";
                    $color = " bgcolor=\"#FFCC66\"";
                }
                if($moduleField[2] > time - $changeBuffer) {
                    $recentChange = " bgcolor=\"#99CCFF\"";
                }
                print "<td$color align=center><div class=table_data><i
+nput type=checkbox name=\"$headers[$dataCount]$moduleCount\" $default
+></div></td><td$recentChange title=\"Changed by $moduleField[1] at $l
+ocaltime\"><div class=table_data>$status</div></td>";
            }
            else {
                if($moduleField[2] > time - $changeBuffer) {
                    $recentChange = " bgcolor=\"#99CCFF\"";
                }
                print "<td$recentChange><div title=\"Changed by $modul
+eField[1] at $localtime\" class=table_data onClick=\"ToggleShowHide('
+label_$headers[$dataCount]$moduleCount','$headers[$dataCount]$moduleC
+ount')\" id=\"label_$headers[$dataCount]$moduleCount\" style='display
+: block;'>$moduleField[0]</div> <div id=\"$headers[$dataCount]$module
+Count\" style='display: none;'><input type=text name=\"$headers[$data
+Count]$moduleCount\" value=\"$moduleField[0]\"><input type=button onC
+lick=\"ToggleShowHide('label_$headers[$dataCount]$moduleCount','$head
+ers[$dataCount]$moduleCount')\" value=OK></div></td>";
            }
            $dataCount++;
        }
        print "</tr>\n";
    }
    $moduleCount++;
    $default = $color = "";
}

[download]

In reply to Foreach Loop Optimization by upallnight

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.