I certainly don't disagree with the previous replies -- they are all true -- but my suggestions are a little different... Instead of this (which is considered harmful):
open(SuitDoc,<STDIN>) || die "Cannot open file"; ... while ($line = <SuitDoc>) { ...
you should just go with the standard idiom:
while (<>) { # read from file name(s) in @ARGV or from pipe ...
Apart from that, you've got your nesting the wrong way around. The outer loop should be over the lines that you read from your input stream, and the inner loop (applied to each line) should be over your patterns. But actually, you don't need an inner loop -- you can let the regex do most of the work:
use strict; # get into this habit my $suits = 'hearts|clubs|spades|diamonds'; while (<>) { if ( /($suits)/ ) { print $1; } }

In reply to Re: Searching Line by Line Multiple Times by graff
in thread Searching Line by Line Multiple Times by Dr.Avocado

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.