GrandFather has pointed out the best solution to your problem using grep and the reason why your code was failing. However, it is sometimes a useful technique, when doing something that might invalidate an index, to consider working back from the end of the array to the beginning. That way you can avoid mucking the index up.

use strict;
use warnings;

my @arr = (9, 0, 0, 5, 3, 0, 0, 0, 2, 0, 1, 0);
print qq{@arr\n};

for my $idx ( reverse 0 .. $#arr )
{
    splice @arr, $idx, 1 unless $arr[$idx];
}
print qq{@arr\n};

[download]

This produces

9 0 0 5 3 0 0 0 2 0 1 0
9 5 3 2 1

[download]

I hope this is useful.

Cheers,

JohnGG

In reply to Re: can't remove all zeroes from an array by johngg
in thread can't remove all zeroes from an array by orange

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.