Code Complete suggests that the optimum size of a method is at 100-200 lines (the data is supported by pseudo-scientific references from the 1980s, too). On the other hand, these numbers should obviously depend on the language used and on the problem solved. Mine are usually much shorter.

Refactoring only because you think your modules are too long is not a really good practice. One should think about what these modules represent and how easy they will be to fix (enormous modules may mean your subs are very tightly coupled, which is not a good thing). If, however, there is no obvious way to split the module's responsibility — it should stay as a whole despite its size.

1000 lines is rather typical and probably fine, though. Unless they are written in a very terse, domain-specific way, of course — count concepts, not lines.

In reply to Re: Is there an ideal module size or subroutine size? by akho
in thread Is there an ideal module size or subroutine size? by talexb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.