$valuestring .= $db->quote({$_}) .",";

[download]
that should give a warning
Odd number of elements in anonymous hash at...
Since {$_} in this instance creates a hash with a single key "$_" and no value.

You want quote($_) instead, though you're probably a lot better off using placeholders.

I.e. something like: 

$db->prepare("INSERT INTO bla col=?, othercol=? ...");
$db->execute($value1,$value2 ...);

[download]
Update: I see that you're using the {$_} in more places, usually where you seem to want $cols{$_} instead. Maybe you should take more notice of the webserver's error log. Or use CGI::Carp 'fatalsToBrowser'; use warnings FATAL=>'all'; or something similar.

"What should it profit a man, if he should win a flame war, yet lose his cool?"

In reply to Re: Receinving hash where expecting a string by Joost
in thread Receinving hash where expecting a string by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.