Assuming you want to insert all values from the hash into your database, you could use the following code:

    my @keys = sort keys %cols;
    my $keystring = join ', ', @keys;
    my $valstring = join ', ', ('?') x scalar @keys;
            
    my $statement = qq{
            INSERT INTO service_metrics ($keystring) 
            VALUES ($valuestring)
            };
    my @values = map { $cols{$_} } @keys;
    my $sth = $dbh->prepare($statement); 

    if (! $sth) {
              die(sprintf('[FATAL] Could not prepare statement: %s\n\n
+ ERRSTR: %s\n', $db->errstr()));
    }
    $sth->execute(@values);
    if (! $sth) {
              die(sprintf('[FATAL] Could not execute statement: %s\n\n
+ ERRSTR: %s\n', $db->errstr()));
            }
    $sth->finish;
    $db->disconnect();
[download]

This is a bit less code and, by using placeholders, guards you against SQL injection.

You can learn more about placeholders in the DBI documentation.

The sorting of the keys eliminates the need to add supply an order manually.

If you have possibly undefined values, change the first line to

my @keys = grep { defined $cols{$_} } sort keys %cols;

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.