A map will not help much here, since you don't need the array that it would return. However, I did notice that the code inside your two foreach loops is identical, suggesting that they should be combined as below. In addition, rather than calculate the uppercase ciphertext letters on the fly, I loaded up a range of letters, scrolled it around the correct number of times, and then shifted it off as needed. I also weeded out the undesirable spaces and forced lowercase key input in that first line of sub key. Same results, but I think it's easier to understand.

use strict;

my %p2C;
my %C2p;
key ('thequickbrownfoxjumpsoverthelazydogs',10);
printKeys(\%p2C);
printKeys(\%C2p);

sub printKeys {
    my $href = shift;
    print "\nCT: ";
    print(($_).' ') foreach (sort keys %{$href});
    print "\npt: ";
    print(($$href{$_}).' ') foreach (sort keys %{$href});
    print "\n";
}

sub key {
    my @kp = grep /[a-z]/, split //, shift;
    my $caesar= shift;
    my @alpha = ('A'..'Z');
    push @alpha, shift @alpha for (1..$caesar);
    foreach (@kp,'a'..'z') {
        if (not exists $p2C{$_}) {
            my $k = shift @alpha;
            $p2C{$_}=$k;
            $C2p{$k}=$_;
        }
    }
}

[download]

Prints:

CT:   a b c d e f g h i j k l m n o p q r s t u v w x y z
pt:   F S Q I M X J L P Z R E A W U B N T C K O D V Y H G

CT:   A B C D E F G H I J K L M N O P Q R S T U V W X Y Z
pt:   m p s v l a z y d g t h e q u i c k b r o w n f x j

[download]

In reply to Re: adapting foreach to map by dogz007
in thread adapting foreach to map by goibhniu

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.